Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-6208: Fix null config directory path in DeleteDomainChecksumsChangeset. #267

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

k4pran
Copy link
Contributor

@k4pran k4pran commented May 28, 2024

Fix NPE issue originating from DeleteDomainChecksumsChangeset. See openmrs/openmrs-core#4637 (comment)

ERROR - Slf4JLogger.log(39) |2024-05-27T01:05:29,953| ChangeSet liquibase.xml::delete-concepts-checksums-20211025::iniz encountered an exception.
java.lang.NullPointerException: null
	at java.base/java.util.Objects.requireNonNull(Objects.java:209) ~[?:?]
	at java.base/sun.nio.fs.UnixFileSystem.getPath(UnixFileSystem.java:263) ~[?:?]
	at java.base/java.nio.file.Path.of(Path.java:147) ~[?:?]
	at java.base/java.nio.file.Paths.get(Paths.java:69) ~[?:?]
	at org.openmrs.module.initializer.api.ConfigDirUtil.<init>(ConfigDirUtil.java:72) ~[initializer-api-2.6.0.jar:?]
	at org.openmrs.module.initializer.api.ConfigDirUtil.<init>(ConfigDirUtil.java:81) ~[initializer-api-2.6.0.jar:?]
	at org.openmrs.module.initializer.liquibase.DeleteDomainChecksumsChangeset.execute(DeleteDomainChecksumsChangeset.java:52) ~

I did duplicate some code from InitializerServiceImpl as it didn't seem there was an easy way to autowire into liquibase customChange classes.

@k4pran k4pran marked this pull request as ready for review June 18, 2024 21:03
@mks-d mks-d changed the title TRUNK-6208 Fix null config directory path TRUNK-6208: Fix null config directory path in DeleteDomainChecksumsChangeset. Jun 25, 2024
@mks-d mks-d merged commit a688fef into mekomsolutions:master Jun 25, 2024
2 checks passed
@mks-d
Copy link
Member

mks-d commented Jun 25, 2024

Thanks @k4pran and @dkayiwa 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants