Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ FILM interpolation nodes #11

Merged
merged 9 commits into from
Jul 7, 2023
Merged

Conversation

melMass
Copy link
Owner

@melMass melMass commented Jul 6, 2023

This just adds a few nodes

Note
Something wen't wrong in the last PR and the submodules where not properly initialised... This PR also fixes that

  • Load FILM Model: Loads a FILM model, the download_model script has been updated to download (L1, Style and VGG)

  • Film Interpolation: The main node that does all the processing. This is quite heavy and memory heavy, there is probably some optimizations possible. <- This is just when using tensorflow cpu, it's like 100x slower

  • Export To ProRes4444: Experimental node that uses ffmpeg stdin to pipe comfy tensor images to a video file.

  • Concat Images: This is probably somewhere builtin but I could not find, it allows to merge IMAGE input of variant batch size but with the same shape otherwise (H,W,C should match)

Todo

  • test in isolation (comfy-embed) to query the minimum required dependencies.

Example:

Using 2 frames, with interpolate = 5 -> result in 33 interpolated frames, played here at 20fps

export

@melMass
Copy link
Owner Author

melMass commented Jul 7, 2023

Merging as it's already growing too much and the base idea of the PR is there

@melMass melMass merged commit 1e28606 into main Jul 7, 2023
@melMass melMass deleted the dev/frame_interpolation branch July 7, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant