Fix unclickable gallery buttons on firefox #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I did not test on non chromium based browsers! Thanks for the PR and support, I'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening the image gallery via the feed in Firefox, the close/next/prev buttons are not clickable.
It appears Firefox doesn't support
pointer-events: bounding-boxon buttons, I'm not sure but after a bit of research it looks like the property is SVG only, and chrome just supports it regardless.PR changes the CSS on the buttons to
pointer-events: auto, confirmed to work on both Firefox and Chrome.I just started using this extension <3 love it so far, so thank you for your hard work.