Fix SMPTE time divisions not being read/written correctly (#275)

melanchall · Oct 8, 2023 · 5f585a7 · 5f585a7
1 parent ddc55c4
commit 5f585a7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/DryWetMidi/Core/TimeDivision/SmpteTimeDivision.cs b/DryWetMidi/Core/TimeDivision/SmpteTimeDivision.cs
@@ -79,7 +79,7 @@ public SmpteTimeDivision(SmpteFormat format, byte resolution)
 
         internal override short ToInt16()
         {
-            return (short)-DataTypesUtilities.Combine((byte)Format, Resolution);
+            return (short)DataTypesUtilities.Combine((byte)-(byte)Format, Resolution);
         }
 
         /// <summary>

diff --git a/DryWetMidi/Core/TimeDivision/TimeDivisionFactory.cs b/DryWetMidi/Core/TimeDivision/TimeDivisionFactory.cs
@@ -10,8 +10,7 @@ internal static TimeDivision GetTimeDivision(short division)
         {
             if (division < 0)
             {
-                division = (short)-division;
-                return new SmpteTimeDivision((SmpteFormat)division.GetHead(), division.GetTail());
+                return new SmpteTimeDivision((SmpteFormat)(-division.GetHead()), division.GetTail());
             }
 
             return new TicksPerQuarterNoteTimeDivision(division);