Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet core compatibility #1

Closed
nicowitteman opened this issue Jul 27, 2017 · 7 comments · Fixed by #36
Closed

dotnet core compatibility #1

nicowitteman opened this issue Jul 27, 2017 · 7 comments · Fixed by #36
Labels
feature request API changes required
Projects

Comments

@nicowitteman
Copy link

Hi!
Any plans for making this library dotnet core-compatible?
Kind regards,
Nico Witteman

@melanchall
Copy link
Owner

melanchall commented Jul 27, 2017

Hi Nico,

Currently I'm not planning to port the library to .NET Core. At now there are not so much users of the DryWetMIDI to proceed with .NET Core compatibility. This task can take some time but currently I'm focused on new features of the library. But maybe in the future I'll come back to your issue :)

Anyway thank you for your interest to the DryWetMIDI! Feel free to open new issues and ask any questions about the library.

Max

@nicowitteman
Copy link
Author

Hi Max,
I switched to framework, and I think the library is very useful. Now I have this issue:
In a MIDI file bwv227.zip
there is a track named "Ténor". In SequenceTrackNameEvent.Text it is represented as "T?nor". That is a pity, because I want to write the tracks away as files with their trackname. This one fails. Any suggestions?
Nico

@melanchall
Copy link
Owner

Hi Nico,

It is because the Text of any text-based meta event is processed in ASCII encoding. Obviously the é symbol doesn't belong this encoding. I'm planning to add other encodings support later. Maybe as a first iteration I will introduce kind of TextEncoding property in ReadingSettings/WritingSettings so you will be able to specify desired encoding for strings serialization/deserialization. Yes, sounds like a plan.

Thank you for your feedback and for remebering me about non-ASCII encodings in text-based meta events. I'll try to provide a solution in the next release which should be at the beginning of August.

Max

@nicowitteman
Copy link
Author

Thanks Max, I will await the update.
Nico

@melanchall
Copy link
Owner

melanchall commented Jul 30, 2017

Nico, I've created separate issue for the non-ASCII encodings support (#2) and moved all our discussion about this problem to the first post of the new issue. All comments on this bug should be placed there. Please press the Subscribe button there to make sure you will recieve all notifications about the issue.

This issue for discussion about .NET Core support only. One problem – one issue. Otherwise it will be difficult for me to maintain list of issues and link commits to specific ones :)

Max

@melanchall
Copy link
Owner

@nicowitteman,

DryWetMIDI 1.2.0 has been released. This release contains a fix for the #2.

@nicowitteman
Copy link
Author

I see I never replied, sorry about that. Thanks Max and a happy new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request API changes required
Projects
DryWetMIDI
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants