wip #388
Merged
wip #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
force-pushed
the
anmonteiro/refactor
branch
from
9d48ec5
to
3b09a13
Compare
anmonteiro
added a commit
that referenced
this pull request
Oct 28, 2022
…ckage-output` (#384) * Lift the restriction that `-bs-package-name` is mandatory for `-bs-package-output` * fix previous test * Fix `-bs-module-type`, get the suffix from the `-o <filename>.bs.js` * fix * update flake.lock * fix package output * no `-nopervasives` * fix some code review items * Separate `Js_packages_info` into "Batch" and "Separate" compilation allows to fix es6 generation from separate compilation in a way that's easier to reason about * Wait until `[@@@bs.config { flags = [| ... |] }]` is processed before dereferencing package specs * wip (#388) * wip * fix / comment * update flake lock * bundle output_info instead of passing suffix and module_system around * refactor: clearer definition of query_package_infos * fix: type error * fix test * refactor: less bindings in `Js_name_of_module_id.string_of_module_id` * refactor: Js_name_of_module_id.get_runtime_module_path * rename function * refactor: improve readability of `Js_name_of_module_id.string_of_module_id`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.