Add no-pkg-flags-to-cmj test #391
Conversation
anmonteiro
force-pushed
the
anmonteiro/javi/386
branch
from
619b449
to
26bf49d
Compare
anmonteiro
force-pushed
the
anmonteiro/javi/386
branch
from
26bf49d
to
69fbf00
Compare
|
|
||
| $ melc -bs-package-output lib/ lib/.objs/melange/a.cmj -o output/lib/a.js | ||
|
|
||
| If we pass some file extension or module system in `-bs-package-output`, it |
There was a problem hiding this comment.
@jchavarri I actually changed this. If you pass bs-package-output with package specs Melange will use that. The correct flag to use to control JS output at this stage is -bs-module-type
There was a problem hiding this comment.
Sounds good.
re: passing -o with file extension and -bs-package-output, I am not sure if we should fail? It's a bit confusing that user can pass file extension in two places.
There was a problem hiding this comment.
it's indeed a bit confusing, but I think we don't need to care about that:
- the CLI interface is for "expert" usage
- people will mostly interact with melange through
melordune
There was a problem hiding this comment.
I think that's one (maybe last?) thing to improve on later. I think the code is a lot cleaner after #384, as there's now a separation between the "package specs" (as recorded in the .cmj -- what's the relative path of this module?) and the output information we'll need for emission ("what module system and JS suffix should this file have?").
Co-authored-by: Javier Chávarri <javier.chavarri@gmail.com>
Re-hash of #386