Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[melange]: remove dependency on rescript syntax #411

Merged
merged 4 commits into from Nov 6, 2022

Conversation

anmonteiro
Copy link
Member

 (rule
  (targets foo.res.pp.ml)
  (deps
   (:inputs foo.res))
  (action
   (with-stdout-to
    %{targets}
    (run rescript_syntax -print=binary %{inputs}))))
  • the melange package is now a lot leaner, and doesn't depend on ocaml-migrate-parsetree

@anmonteiro anmonteiro merged commit db88952 into main Nov 6, 2022
@anmonteiro anmonteiro deleted the anmonteiro/dont-depend-on-napkin branch November 6, 2022 18:54
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Nov 6, 2022
CHANGES:

- [melange] Introduce 2 explicit modes of JavaScript compilation:
  - "Batch compilation": produces `.cmj` and `.js` files at the same time (this
    is the previous behavior -- using `--bs-package-output
    MODULE_SYSTEM:REL_PATH:JS_EXTENSION`)
  - "Separate emission": produces _only_ `.cmj` files with `--bs-stop-after-cmj
    --bs-package-output REL_PATH_ONLY`, and allows emitting JavaScript files
    separately, with `--bs-module-type MODULE_SYSTEM -o
    TARGET_FILE.JS_EXTENSION`
  ([melange-re/melange#384](melange-re/melange#384))
- [mel]: Fix `mel build --watch` exiting after the first change
  ([melange-re/melange#401](melange-re/melange#401))
- [melange]: Remove dependency on `reason`. Reason syntax users should install`
  reason` from their preferred package manager instead, and Melange / Dune will
  find it in `$PATH` ([melange-re/melange#409](melange-re/melange#409))
- [melange]: Remove dependency on `napkin` (the ReScript syntax parser). Users
  that depend on libraries written in ReScript syntax should install the `mel`
  package and Melange / Dune will find the `rescript_syntax` binary in `$PATH`
  ([melange-re/melange#411](melange-re/melange#411))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant