warning 61 shown in externals #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
force-pushed
the
warning-61-external
branch
from
d1a89e4
to
a93b183
Compare
anmonteiro
added a commit
that referenced
this pull request
Nov 13, 2022
anmonteiro
added a commit
that referenced
this pull request
Nov 13, 2022
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Nov 16, 2022
CHANGES: - Disable warning 69 (`unused-field` in record) for the private record generated by the `bs.deriving` attribute ([melange-re/melange#414](melange-re/melange#414)) - Disable warning 20 (`ignored-extra-argument`) when applying `foo##fn arg1 arg2` ([melange-re/melange#416](melange-re/melange#416)): - in cases such as `external x : < .. > Js.t = ""`, the typechecker doesn't know the arity of the function, even though Melange will emit an uncurried function call. - Disable warning 61 (`unboxable-type-in-prim-decl`) in `external` declarations ([melange-re/melange#415](melange-re/melange#415)): - Melange externals are substantially different from OCaml externals. This warning doesn't make sense in a JS runtime. - melc: introduce `--bs-module-name` flag to specify the original file name for the current compilation unit ([melange-re/melange#413](melange-re/melange#413)) - Dune's namespacing implementation generates modules such as `lib__Original_name`. Passing `--bs-module-name original_name` allows melange to issue correct `import` / `require` statements to the unmangled JS file names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just showcasing another case where a warning that was added in recent versions (in this case 61 [unboxable-type-in-prim-decl]) appears on externals.
Not sure if this one in particular is something that could be fixed on Melange side, or it's maybe more documentation related, but I hope it's worth opening the PR for discussion.