test: show bad location in empty interpolation error #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
force-pushed
the
anmonteiro/show-empty-interpolation-location-bug
branch
from
ca62a64
to
f4f814f
Compare
anmonteiro
added a commit
that referenced
this pull request
Nov 14, 2023
anmonteiro
force-pushed
the
anmonteiro/show-empty-interpolation-location-bug
branch
from
a0865fd
to
b55806d
Compare
anmonteiro
commented
Nov 14, 2023
| @@ -172,15 +172,6 @@ let suites = | |||
| Invalid_syntax_of_var " (" ) -> | |||
| OUnit.assert_bool __LOC__ true | |||
| | _ -> OUnit.assert_bool __LOC__ false ); | |||
| ( __LOC__ >:: fun _ -> | |||
There was a problem hiding this comment.
this test was duplicated with the one I changed below.
anmonteiro
deleted the
anmonteiro/show-empty-interpolation-location-bug
branch
jchavarri
reviewed
Nov 14, 2023
| $ melc -ppx melppx x.ml | ||
| File "x.ml", line 1, characters 20-23: | ||
| 1 | let x = {j| Hello, $()|j} | ||
| ^^^ |
There was a problem hiding this comment.
Is this on the right location? Seems it's picking ()| rather than $().
There was a problem hiding this comment.
Sorry, after reading the title, it's unclear to me if the PR was created to showcase this bad location or to fix it.
There was a problem hiding this comment.
oh good point, I guess we could move it backwards yet one more char.
The first commit shows the wrong location, and the 2nd commit fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.