Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js.Re: add labeled argument #989

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Js.Re: add labeled argument #989

merged 2 commits into from
Dec 18, 2023

Conversation

jchavarri
Copy link
Member

Maybe it makes sense to add labeled args to Js.Re for consistency with Js.String, Js.Array...

cc @davesnx

Copy link
Member

@anmonteiro anmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thanks!

@anmonteiro anmonteiro merged commit 3d7b0aa into main Dec 18, 2023
4 checks passed
@anmonteiro anmonteiro deleted the js-re-add-label-arg branch December 18, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants