Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ppx): report structured PPX alerts #991

Merged
merged 3 commits into from
Dec 18, 2023
Merged

fix(ppx): report structured PPX alerts #991

merged 3 commits into from
Dec 18, 2023

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Dec 18, 2023 •
edited

fixes #876

  • PPX alerts are printed with Ocaml_common.Location.prerr_alert:

    melange/ppx/mel_ast_invariant.ml

    Line 64 in bb932a7

    let module Location = Ocaml_common.Location in
  • before this change, they were using the default reporter and printed to stdout (in the playground, that's the browser console)
  • after this change, we register the playground's custom alert printer on Ocaml_common.Location in addition to the Melange_compiler_libs registration

@anmonteiro anmonteiro merged commit cff08e9 into main Dec 18, 2023
4 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/playground-fix-ppx-alerts branch December 18, 2023 17:24
@jchavarri jchavarri mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchavarri jchavarri Awaiting requested review from jchavarri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

playground: alerts from the ppx are not shown
1 participant
@anmonteiro