Remove itemClass usage from most places

meldra · Dec 9, 2011 · a58f74f · a58f74f
1 parent efd35f2
commit a58f74f
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 11 deletions.
diff --git a/XML/Feed/Parser/Atom.php b/XML/Feed/Parser/Atom.php
@@ -150,7 +150,8 @@ function getEntryById($id)
         if ($entries->length > 0) {
             $xmlBase = $entries->item(0)->baseURI;
             /** @todo Avoid instantiating classes we can't keep track of */
-            $entry = new $this->itemClass($entries->item(0), $this, $xmlBase);
+            $entry = new XML_Feed_Parser_AtomElement($entries->item(0), $this, $xmlBase);
+            $entry->setSanitizer($this->getSanitizer());
 
             if (in_array('evaluate', get_class_methods($this->xpath))) {
                 $offset = $this->xpath->evaluate("count(preceding-sibling::atom:entry)", $entries->item(0));

diff --git a/XML/Feed/Parser/RSS09.php b/XML/Feed/Parser/RSS09.php
@@ -105,13 +105,12 @@ class XML_Feed_Parser_RSS09 extends XML_Feed_Parser_Type
     function __construct(DOMDocument $model, $strict = false)
     {
         $this->model = $model;
-
+        $this->setSanitizer(new XML_Feed_Parser_Unsafe_Sanitizer());
         $this->xpath = new DOMXPath($model);
         foreach ($this->namespaces as $key => $value) {
             $this->xpath->registerNamespace($key, $value);
         }            
         $this->numberEntries = $this->count('item');
-        $this->setSanitizer(new XML_Feed_Parser_Unsafe_Sanitizer());
     }
 
     /**

diff --git a/XML/Feed/Parser/RSS1.php b/XML/Feed/Parser/RSS1.php
@@ -155,8 +155,7 @@ function getEntryById($id)
 
         $entries = $this->xpath->query("//rss:item[@rdf:about='$id']");
         if ($entries->length > 0) {
-            $classname = $this->itemClass;
-            $entry = new $classname($entries->item(0), $this);
+            $entry = new XML_Feed_Parser_RSS1Element($entries->item(0), $this);
             if (in_array('evaluate', get_class_methods($this->xpath))) {
                 $offset = $this->xpath->evaluate("count(preceding-sibling::rss:item)", $entries->item(0));
                 $this->entries[$offset] = $entry;

diff --git a/XML/Feed/Parser/RSS11.php b/XML/Feed/Parser/RSS11.php
@@ -121,7 +121,7 @@ class XML_Feed_Parser_RSS11 extends XML_Feed_Parser_Type
     function __construct(DOMDocument $model, $strict = false)
     {
         $this->model = $model;
-
+        $this->setSanitizer(new XML_Feed_Parser_Unsafe_Sanitizer());
         if ($strict) {
             if (! $this->relaxNGValidate()) {
                 throw new XML_Feed_Parser_Exception('Failed required validation');
@@ -133,7 +133,7 @@ function __construct(DOMDocument $model, $strict = false)
             $this->xpath->registerNamespace($key, $value);
         }            
         $this->numberEntries = $this->count('item');
-        $this->setSanitizer(new XML_Feed_Parser_Unsafe_Sanitizer());
+
     }
 
     /**
@@ -156,8 +156,7 @@ function getEntryById($id)
 
         $entries = $this->xpath->query("//rss:item[@rdf:about='$id']");
         if ($entries->length > 0) {
-            $classname = $this->itemClass;
-            $entry = new $classname($entries->item(0), $this);
+            $entry = new XML_Feed_Parser_RSS1Element($entries->item(0), $this);
             return $entry;
         }
         return false;

diff --git a/XML/Feed/Parser/RSS2.php b/XML/Feed/Parser/RSS2.php
@@ -114,7 +114,7 @@ class XML_Feed_Parser_RSS2 extends XML_Feed_Parser_Type
     function __construct(DOMDocument $model, $strict = false)
     {
         $this->model = $model;
-
+        $this->setSanitizer(new XML_Feed_Parser_Unsafe_Sanitizer());
         if ($strict) {
             if (! $this->relaxNGValidate()) {
                 throw new XML_Feed_Parser_Exception('Failed required validation');
@@ -126,7 +126,6 @@ function __construct(DOMDocument $model, $strict = false)
             $this->xpath->registerNamespace($key, $value);
         }
         $this->numberEntries = $this->count('item');
-        $this->setSanitizer(new XML_Feed_Parser_Unsafe_Sanitizer());
     }
 
     /**

diff --git a/XML/Feed/Parser/Type.php b/XML/Feed/Parser/Type.php
@@ -210,6 +210,8 @@ function getEntryByOffset($offset)
             $entries = $this->model->getElementsByTagName($this->itemElement);
             if ($entries->length > $offset) {
                 $xmlBase = $entries->item($offset)->baseURI;
+                /** @todo Remove this behaviour - each driver should control this better */
+                /** @todo Try to avoid new here */
                 $this->entries[$offset] = new $this->itemClass(
                     $entries->item($offset), $this, $xmlBase);
                 if ($id = $this->entries[$offset]->id) {