Correctly select alternate links as per RFC4287

meldra · Nov 29, 2011 · b44c879 · b44c879
1 parent 0f4ce99
commit b44c879
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/XML/Feed/Parser/Atom.php b/XML/Feed/Parser/Atom.php
@@ -347,15 +347,18 @@ function getLink($offset = 0, $attribute = 'href', $params = false)
         } else {
             $links = $this->model->getElementsByTagName('link');
         }
-        if ($links->length > $offset) {
-            if ($links->item($offset)->hasAttribute($attribute)) {
-                $value = $links->item($offset)->getAttribute($attribute);
+        foreach ($links as $link) {
+            if ($link->hasAttribute($attribute)
+                && ($link->hasAttribute('rel') == false
+                || $link->getAttribute('rel') == 'alternate')
+            ) {
+                $value = $link->getAttribute($attribute);
                 if ($attribute == 'href') {
-                    $value = $this->addBase($value, $links->item($offset));
+                    $value = $this->addBase($value, $link);
                 }
                 return $value;
             } else if ($attribute == 'rel') {
-                return 'alternate';
+                return $link->getAttribute($attribute);
             }
         }
         return false;