Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players see remaining HP of NPCs when using Damage NPC macro #7

Closed
Merudo opened this issue May 11, 2020 · 3 comments
Closed

Players see remaining HP of NPCs when using Damage NPC macro #7

Merudo opened this issue May 11, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Merudo
Copy link

Merudo commented May 11, 2020

Describe the bug
Players see the remaining and total HP of NPCs when using the Damage NPC macro. This info should be only be available to the GM.

To Reproduce
Steps to reproduce the behavior:

  1. As a player, use the Damage NPC macro on a NPC
  2. The output you get gives a lot of info: Dragon's updated HP: 8/10 (took 1)
@Merudo Merudo added the bug Something isn't working label May 11, 2020
@melek
Copy link
Owner

melek commented May 11, 2020

Thanks for catching this; I'm a bit surprised nobody had complained about it before!

@melek
Copy link
Owner

melek commented May 13, 2020

I've added checks to the Damage NPC and Heal NPC macros to prevent players from running them on tokens they do not own. When run on their own tokens, they will work nearly identically to the Heal/damage macros on their own tokens.

I almost added similar code to Roll Initiative and any conditions that might change properties, but decided not to add the weight (and code duplication).

  • Update Campaign File
  • Update Wiki
  • Update Update Token

@melek
Copy link
Owner

melek commented May 13, 2020

Waiting on #10 to close.

@melek melek closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants