Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce webrtc dependency to a single one #3

Conversation

thomaseizinger
Copy link

Description

Depending on the recent webrtc master branch breaks a couple of things because of the move to the monorepo I assume. To ensure CI stability of our dev branch, we pin the dependency to a specific hash. At the same time, depending on the various subcrates may result in mismatching versions. To avoid this, we remove those dependencies and import the modules via the re-export from the root webrtc crate.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger
Copy link
Author

I can't request a review but would appreciate one from @melekes and @mxinden!

Copy link
Owner

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thomaseizinger
Copy link
Author

Feel free to merge at any time @melekes! (I can't.)

@melekes melekes merged commit 3effb2e into melekes:anton/webrtc-transport Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants