Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transports/webrtc: Implement stream message framing #9

Closed
wants to merge 14 commits into from

Conversation

melekes
Copy link
Owner

@melekes melekes commented Sep 19, 2022

Description

Implements mxinden/specs#1 for libp2p#2622.

TODOs:

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@melekes melekes changed the base branch from master to anton/webrtc-transport September 19, 2022 12:29
Copy link

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far! Thanks for addressing the comments :)

Are you going to have time to address the tests? Otherwise I can add them.

@melekes
Copy link
Owner Author

melekes commented Sep 23, 2022

Are you going to have time to address the tests? Otherwise I can add them.

Please go ahead

@thomaseizinger
Copy link

I am going to address the tests by working on libp2p#508.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants