Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dict): Make update-db script resilient to multiple spaces separating kanji entry fields #1917

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix(dict): Make update-db script resilient to multiple spaces separating kanji entry fields #1917

merged 1 commit into from
Jan 2, 2024

Conversation

melink14
Copy link
Owner

@melink14 melink14 commented Jan 2, 2024 •
edited

Fixes #1913

@melink14 melink14 changed the title fix(db): Make update-db script resilient to multiple spaces separating kanji entry fields fix(dict): Make update-db script resilient to multiple spaces separating kanji entry fields Jan 2, 2024
@melink14 melink14 added the self-approved Label which allows mergify to approve owner's PRs label Jan 2, 2024
mergify[bot]
mergify bot approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

melink14 says it's fine so it must be fine!

@mergify mergify bot merged commit d101ec8 into main Jan 2, 2024
17 checks passed
@mergify mergify bot deleted the melink14/fix-kanjidic branch January 2, 2024 04:03
melink14 pushed a commit that referenced this pull request Jan 2, 2024
@semantic-release-bot
chore(release): 2.5.37
d5d79ad 
## [2.5.37](v2.5.36...v2.5.37) (2024-01-02)

### Bug Fixes

* **dict:** Make update-db script resilient to multiple spaces separating kanji entry fields ([#1917](#1917)) ([d101ec8](d101ec8)), closes [#1913](#1913)
@melink14
Copy link
Owner Author

melink14 commented Jan 2, 2024

🎉 This PR is included in version 2.5.37 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify approved these changes

Assignees
No one assigned
Labels
released self-approved Label which allows mergify to approve owner's PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not parse kanji entry for 解 in 2023-12-25 dictionary
1 participant
@melink14