Encapsulate rikaikun popup in shadowdom to prevent weird interactions with host page #221
Assignees
Labels
Code health
Issues which if fixed would improve the health of the project (as opposed to new features/bugs)
easy
enhancement
good first issue
released
Comments
melink14
added
enhancement
easy
Code health
melink14
added a commit
that referenced
this issue
Apr 2, 2022
…ll: revert` - Creates a div inside of shadow root to contain all styles and modifications. - Updates CSS to use `all: revert` instead of previous adhoc reset. - Installs CSS directly into the shadow DOM as per best practices. - Fallsback to `all: initial` for older Chrome browsers. - Removes special check for text files since chrome renders them as normal HTML pages. Fixes #221
melink14
added a commit
that referenced
this issue
Apr 2, 2022
…ll: revert` (#933) * feat(ui): Isolate rikaikun popup from host page via shadow Dom and `all: revert` - Creates a div inside of shadow root to contain all styles and modifications. - Updates CSS to use `all: revert` instead of previous adhoc reset. - Installs CSS directly into the shadow DOM as per best practices. - Fallsback to `all: initial` for older Chrome browsers. - Removes special check for text files since chrome renders them as normal HTML pages. Fixes #221
melink14
pushed a commit
that referenced
this issue
Apr 4, 2022
## [2.3.0](v2.2.5...v2.3.0) (2022-04-04) ### Features * **ui:** Isolate rikaikun popup from host page via shadow DOM and `all: revert` ([#933](#933)) ([e6a6e7a](e6a6e7a)), closes [#221](#221) ### Bug Fixes * **detection:** Copy text affecting style properties of input/textarea elements when creating fake ([#886](#886)) ([23fc0df](23fc0df)), closes [#672](#672) * **dict:** Update dictionaries to latest versions ([#954](#954)) ([deae6f5](deae6f5)) * **ui:** Only show info popups in the main frame of a tab ([#948](#948)) ([90c7b21](90c7b21))
|
🎉 This issue has been resolved in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, there's a CSS reset in rikaikun to avoid most issues but using shadow dom should be more scalable.
It also will allow us to simply CSS since it will be scoped.
References:
https://developers.google.com/web/fundamentals/web-components/shadowdom
Maybe useful example: https://blog.railwaymen.org/chrome-extensions-shadow-dom
The text was updated successfully, but these errors were encountered: