でした not recognized

[GoogleCodeExporter]

What steps will reproduce the problem?
1.It doesn't recognize "でした" (was/were);
2.In "Options", only "General" is active. 


What version of the product are you using? On what operating system?

Version 0.8.5, on Google Chrome.

Original issue reported on code.google.com by ciccio.d...@gmail.com on 23 Jul 2013 at 12:44

[GoogleCodeExporter]

It does, but it doesn't list enough options for you to see it.  For hiragana 
words this can be a problem since they match so many things.

Yes, the rest of the options need to be implemented.  There's another bug you 
can star for that.

Original comment by melin...@gmail.com on 23 Jul 2013 at 12:46

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

this is the outcome. can it be corrected?

Original comment by ciccio.d...@gmail.com on 23 Jul 2013 at 12:52

Attachments:

• Immagine.png

[GoogleCodeExporter]

Not right now.

There are possibilities.  An option that increased the number of results that 
the pop up showed, maybe an option that turned of matching hirgana to kanji, 
though that would have some false positives.

A quick work around now though is to remember what desu and it's conjugations 
mean. :)

Original comment by melin...@gmail.com on 23 Jul 2013 at 12:54

[GoogleCodeExporter]

it was my duty to report the defect! I know です and its forms by heart!
rikaikun is a wonderful software! ありがとうございました

Original comment by ciccio.d...@gmail.com on 23 Jul 2013 at 1:06

[GoogleCodeExporter]

Thank You!

Don't mean to criticize.  All bug reports are welcome!

I don't update rikaikun enough but thanks for using it!

Original comment by melin...@gmail.com on 23 Jul 2013 at 1:12

[GoogleCodeExporter]

I don't know why, but the only tab I can use in Options is General. I think the 
problem might lie in the error shown in the attached screenshot.

Original comment by marcusc4444@gmail.com on 29 Nov 2013 at 1:51

Attachments:

• Untitled.png

[GoogleCodeExporter]

Nevermind. I fixed the error by editing options.css, and the issue persists...

Original comment by marcusc4444@gmail.com on 29 Nov 2013 at 1:55

[melink14]

This seems to have changed. I would have thought でした would be deinflected to です but it doesn't seem to be so maybe there's another bug.

[melink14]

Should be easy to look at deinflection code and figure out what it does when given でした.

[maawisul]

I take a look at the dictionary and find that there is no entry for でした unlike です so any でした followed by nouns will not be recognized by the extension. (there is a ませんでした in deinflect.dat so verbs will be recognized correctly.)

So should the fix still be implemented on the code or can I add an entry of でした directly in the dictionary files?

[melink14]

That's a good observation and investigation. Thanks!

As you expected, it should be enough to update deinflect.dat so that it handles this congutation and outputs the です entry when you hover でした.

The problem is that I think it should already be happening! Since there's a line in deinflect.data which changes した to す:

rikaikun/extension/data/deinflect.dat

Line 235 in e85f33b

した す 640 14

So the reason for inspecting the code which handles the deinflection data is to figure out why that transformation isn't happening. It could be that the code has special logic for detecting verbs which excludes です for example. In that case, it's probably safest to add an entry to deinflect.dat to handle the case as you mentioned.

In summary, I'd suggestion two steps:

1. Figure out why the current deinflect.dat doesn't work.
2. Update it with a でした -> です entry if there's a good reason that the current した -> す shouldn't apply.

#257 is related since it's about creating a better system for handling that data though it should be possible to update without a big rewrite just by looking at the references in that issue.

[maawisul]

Thank you for the quick response!
I will continue working on this issue and come back if I have further questions.

[maawisul]

I get rikaikun to recognize でした as です by adding one more conditional after line 495,
https://github.com/maawisul/rikaikun/blob/47ff1a062f23713ab3ef2a6d9dc9b08295352f85/extension/data.ts#L496-L498

Should I submit a pull request?

[melink14]

I saw your PR so will look at it over there.

In general, for small changes sending PR is always fine since the worst that can happen is that changes are requested. Thanks for checking!

[melink14]

We decided that です was too different to reuse verb logic so the way forward is to add a definflection type for the copula as described in #988

[melink14]

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on:

• Chrome Web Store
• GitHub release

Your semantic-release bot 📦🚀