-
-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 0.74 - Update defaultProps to JavaScript default parameters. #661
Comments
same issue as @nd-gorm |
same issue as @nd-gorm .-) |
Same, after upgrading to react native 0.74 |
Same issue here. But the question is: is this project still alive? |
I see attempts to fix this (f0c7e34). But they failed the test. |
I reached out with an offer to sponsor and have not heard back, so I have similar concerns. Perhaps time for a fork? Or perhaps @meliorence can add a maintainer. |
same here, will show the warning as below
Version:
|
@djMax and @ba361006 https://www.npmjs.com/package/htmlparser2-without-node-native |
But this doesn't do any of the translation to React components, no? That's the main magic bit of this module, IMHO. |
No, I just needed to display the users html in the View |
The CI step that failed when merging a fix in #658 was a linting step. Lint errors were fixed in #660, in which regarding the potential for a release the maintainer said, "I cannot promise anything, but will consider releasing when I find some time off." So, a fix may be released, but not on any definite timeline. |
Also looking forward to the fix release |
same issue as @nd-gorm |
Same issue as @nd-gorm |
same issue as @nd-gorm |
Is there any solution ? |
I solved switching to this library while waiting for a fix react-native-html-text-view. |
Thank you so much. |
I switched to react-native-htmlview and it's working fine so far; smooth transation. |
@jsamr any update? |
same issue |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @builder.io/sdk-react-native@1.0.34 ### Patch Changes - c787998: Fix: add `regeneratorRuntime` polyfill - c787998: Fix: replace `react-native-render-html` with `@builder.io/react-native-render-html` to remove `defaultProps` errors. See <meliorence/react-native-render-html#661> - c787998: Fix: disable async storage during static rendering (node.js) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Decision Table
<yyy>
is not rendered”Good Faith Declaration
Description
Hi it seems most components are setup to use TS defaultProp, which will be removed from function components.
I suppose this future error is present in all components using defaultProps.
React Native Information
RNRH Version
6.3.4
Tested Platforms
Reproduction Platforms
Minimal, Reproducible Example
Run in a React Native project >= 0.74
Additional Notes
No response
The text was updated successfully, but these errors were encountered: