Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Hotfix for onChange event #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kgrosvenor
Copy link

I noticed issues with the onChange event not always being updated towards strapi, now it does and allows empty blocks, pasting blocks from other windows, ctrl+a and backspace.

My IDE was flagging up value twice in the WYSIWYG properties so I have omitted the second declaration made

@kgrosvenor kgrosvenor changed the title Hotfix/on change event Hotfix for onChange event Apr 23, 2022
@melishev
Copy link
Owner

melishev commented May 5, 2022

I just tested your changes and I didn't see any change in behavior

@kgrosvenor
Copy link
Author

kgrosvenor commented May 18, 2022

@melishev Have you tested diffferences between two version as i feel you did not:

Try these steps

  • Pasting content from one editor to another and saving, do blocks update on next article load, .i.e when you refresh strapi after Saving?
  • Try to save strapi article after CTRL + A and backspace (remove all), save it and then reload the page after Saving, is blocks empty (should be?)

It doesn't let you in current version, please retest from this angle and you'll see what i mean.

I have this running in strapi and it works better, its tricky to show difference but there is, it needs more edge case testing too see the issues though.

Hope all is well 👍

@melishev
Copy link
Owner

melishev commented Sep 2, 2022

@kgrosvenor Okay, but conflicts need to be resolved before I can merge.

@melishev melishev self-requested a review September 2, 2022 13:12
@SalahAdDin
Copy link

@kgrosvenor Did you fix all the conflicts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants