Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Fix bug missing some attributes on image component #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nhvu1988
Copy link
Contributor

@nhvu1988 nhvu1988 commented May 7, 2022

As I think the image block shoulds contain the original Strapi image information such as alternativeText, name, ext, provider_metadata ... instead of removing or customizing it. So it keeps the consistent with other plugins that may use them.

@melishev
Copy link
Owner

melishev commented Sep 2, 2022

@nhvu1988 This change will significantly increase the size of the content. Need to get more attention from other people who need these changes

@SalahAdDin
Copy link

SalahAdDin commented Oct 9, 2022

@nhvu1988 This change will significantly increase the size of the content. Need to get more attention from other people who need these changes

At least the preview URL is very important for improving SEO(in NextJS, for instance).

So, what could be a better solution?

However, it seems the Cloudinary plugin is not saving the previewURL.

@bmfs
Copy link

bmfs commented Oct 10, 2022

Maybe adding an option to the plugin config to include the metadata could be a good compromise on the concern of the increased content size.

@melishev
Copy link
Owner

Maybe adding an option to the plugin config to include the metadata could be a good compromise on the concern of the increased content size.

@bmfs This could be a solution, can you prepare these changes?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants