Adds environment variables #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like something closer to the environment(mapOf("JAVA_HOME" to System.getenv("JAVA_HOME")))
environment("JAVA_HOME", System.getenv("JAVA_HOME"))And I am not sure how best to proceed. Same for the tests. |
Sometimes it is necessary to pass some environment variables to configure the JVM process (in particular when native libraries are involved). And when there's no system property equivalent, or when it's not possible to do in the benchmark setup (e.g. `LD_PRELOAD`, `JAVA_LIBRARY_PATH`). Alas, JMH does not support to set environment variable on the forked process, however it will propagate the ones that it has been launched with. E.g. ``` env JAVA_LIBRARY_PATH=/somewhere java -jar bench.jar ``` This change aims at providing the ability to pass the variable to JMH so it cna be used on the JMH forked process.
|
Wow I wonder how the PR description was empty, was it me that forgot 🤔🤦 ? |
melix
requested changes
Mar 28, 2022
Drop the parameter conversion indirection
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change is about the support of environment variables when launching the jmh jar. (Because the
org.openjdk.jmh.annotations.Forkdon't allow to pass environments).The jmh block is of type
JmhParametersandWithJavaToolchainso in order to support a similar API asJavaExecSpecit has to be explicitly exposed.Current alternative
The currently API does not allow this so we have to executes the jmh jar outside gradle.
Note
I didn't see a functional test with jmh options so I'm not sure how you'd want to test that.