Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Documentation Improvements #91

Merged
merged 3 commits into from
Mar 29, 2018
Merged

Documentation Improvements #91

merged 3 commits into from
Mar 29, 2018

Conversation

matnguyen
Copy link
Contributor

@matnguyen matnguyen commented Mar 28, 2018

Description

Edited Readme to improve clarity and concision as well as making it more formal. Some typos were also corrected.

Also fixed typos in CONTRIBUTING.md

Type

Documentation

Checklist

Check the checkbox(es) that apply.

  • I have read the CONTRIBUTING guide.
  • ./build.sh is passing with every build step and every test locally.
  • I have added tests that prove my fix is effective or that my feature works.
  • I tested it on Linux and on Windows and it's working as intended.

Reviewers

@Marc3842h, ...

Edited Readme to improve clarity and concision as well as making it more formal.  Some typos were also corrected.
@mellowagain mellowagain added status: waiting Waiting for a response or work to be done on this issue... type: documentation labels Mar 28, 2018
@mellowagain
Copy link
Owner

mellowagain commented Mar 28, 2018

Looks good from the first look over it, could you also update the comments in the accounts.json standalone file?

Also I've been thinking about changing a few parts in the contributor file as I require a passing on both Windows and Linux now.

EDIT: Also please provide your Discord username so I can give you the contributor role on our Discord (if you joined it).

Matched comments in accounts.json to README.md
@matnguyen
Copy link
Contributor Author

The comments have been edited!

I haven't joined the Discord.

@mellowagain
Copy link
Owner

Thanks!

@mellowagain mellowagain merged commit 83a845b into mellowagain:master Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: waiting Waiting for a response or work to be done on this issue... type: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants