Change InputConfig images #1724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes Non-commerical SVG files that are a GPL violation
|
Any update on possibly getting this merged? I'm open to any feedback you might have. |
|
Are the new images good as a drop-in replacement? |
|
Not currently since I haven't made one for the shoulder buttons. Currently, the input config window has the shoulder button prompts on the corners of the open DS image. |
nadiaholmquist
force-pushed
the
master
branch
from
10c70eb
to
a7575ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SVG image files that are used in the Qt frontend's InputConfig UI have a non-commercial license which is incompatible with melonDS's GPL-3.0-or-later license. The SVG files were originally merged in #1226. I found an image of the Nintendo DS's layout at this repo. This image is under the BSD-3-Clause license so there are not licensing issues. I used that image as a basis to create the
ds_open.svgincluded in this pull request.I was not able to create a layout for the shoulder buttons since I could not find a reference. Maybe I will take a picture of my DS Lite when I get access to it again. Please let me know any changes you would like me to make. I am happy to help.
Also, thanks so much for creating and maintaining this amazing project.