Implementing the use of the touchscreen as camera movement #1896

vitor251093 · 2023-11-30T02:27:32Z

Basically, this changes allows a user to use keys (or an analog joystick) to move the camera by using the touchscreen.

This method, ofc, is only useful for games which allow you to use the touchscreen to move the camera, such as Kingdom Hearts 358/2 Days.

There is still room for improvement. The movement could be smoother, and, when using an analog stick, the camera movement could move more or less depending on how tilted is the analog stick. Still, this implementation is already useful as it is.

Updating base repository

JesseTG · 2023-11-30T05:10:06Z

src/SPI.cpp

@@ -462,6 +462,30 @@ void TSC::SetTouchCoords(u16 x, u16 y)
    NDS.KeyInput &= ~(1 << (16+6));
 }

+void TSC::MoveTouchCoords(u16 x, u16 y) // 0 -> negative, 1 -> neutral, 2 -> positive


Do you think you could make this an enum instead of a series of magic numbers? I could easily see some poor bastard trying to pass mouse coordinates in here, wondering why nothing works.

Sure. Any preferable place where I should place the enum?

SPI.h would be my first instinct.

enum added, but now I'm wondering if replacing x and y enums with left, top, right and down booleans wouldn't make more sense lol

What do you think @JesseTG ?

Oh, sorry, I didn't think you were asking me the first time.

No, keep the two-argument version; the "cursor" can move along both axes, right?

That's correct

JesseTG · 2023-12-02T18:02:42Z

src/DSi_SPI_TSC.cpp

@@ -121,6 +121,11 @@ void DSi_TSC::SetTouchCoords(u16 x, u16 y)
    }
 }

+void DSi_TSC::MoveTouchCoords(SPITouchScreenMovement x, SPITouchScreenMovement y)


Is there a reason that DSi_TSC's override of this method does nothing?

Oh, sorry, I forgot to mention that.

I've only tested the touchscreen camera controls with the DS mode, but not with the DSi mode. Since the implementation of SetTouchCoords was different for each of them, I decided to include that override to avoid unexpected behaviours. At the time I had implemented that only for KH Days, so there was no use in implementing that function either.

I can make some tests with the DSi mode to implement that function, but that may take a little while.

Yes, I think that would be for the best.

RSDuck · 2023-12-03T03:37:40Z

why does this touch the core at all, looks to me like something which could be implemented on the frontend side only?

vitor251093 · 2023-12-03T07:36:23Z

why does this touch the core at all, looks to me like something which could be implemented on the frontend side only?

Because the input only allow me to update an existing coordinate within the touchscreen, requiring me to know the previous value, while TouchX and TouchY are protected values.

So I either needed to add a function to SPI which updates TouchX and TouchY based on the movement (which was my approach), or I would need to make TouchX and TouchY public (so I could extract that logic to NDS.cpp).

EDIT: It's also worth noting that, based in the DSi SPI class, TouchX and TouchY have different possible values for the DS and the DSi (the DSi ones also include the touch/release states). With that, obtaining TouchX and TouchY would actually be a problem, so I would need to maintain two new variables at NDS.h/NDS.cpp, or main.cpp, instead.

I can update the pull request to achieve that approach if you want. But like I told Jesse before, this may take a little while.

CasualPokePlayer · 2023-12-03T07:57:45Z

With that, obtaining TouchX and TouchY would actually be a problem, so I would need to maintain two new variables at NDS.h/NDS.cpp, or main.cpp, instead.

It wouldn't really be that hard to just mask out stuff you don't need, a simple & ~0x8000 and checking if the value is 0x700 (and probably checking if y == 0xFFF for DS mode) would work (or maybe a getter would do most of that for you)

JesseTG · 2023-12-03T15:00:34Z

or I would need to make TouchX and TouchY public (so I could extract that logic to NDS.cpp).

Is there a reason you can't add GetTouchX() and GetTouchY() to expose these members without letting them be modified arbitrarily?

vitor251093 · 2023-12-03T16:33:50Z

or I would need to make TouchX and TouchY public (so I could extract that logic to NDS.cpp).

Is there a reason you can't add GetTouchX() and GetTouchY() to expose these members without letting them be modified arbitrarily?

I will try to do that, following @CasualPokePlayer 's suggestion. Seems to be an approach that will fit all the needs we talked about.

I will leave a comment here once I have time to code, and test, the needed changes.

vitor251093 · 2023-12-05T02:01:59Z

Alright, just finished implementing the changes.

The SPIs now were only changed to add the getters, and the logic that converts inputs into touchscreen movements is now contained within NDS::SetTouchKeyMask.

Also now it can also detect every scenario when the coordinates becomes out of bounds, which is then considered as the touchscreen being released, so the movement can restart on the next frame starting from the middle of the touchscreen.

Updating base branch

vitor251093 · 2023-12-15T00:28:30Z

I just realized there was a conflict. Fixed it

vitor251093 and others added 2 commits November 29, 2023 18:57

Merge pull request #42 from melonDS-emu/master

322f92f

Updating base repository

Implementing the use of the touchscreen as camera movement

d96abdf

JesseTG reviewed Nov 30, 2023

View reviewed changes

Adding enum to make code more readable

14eadfb

JesseTG reviewed Dec 2, 2023

View reviewed changes

vitor251093 added 3 commits December 4, 2023 22:45

Extracing logic from SPI

725e180

Moving enum from SPI.h to NDS.h

503daea

Simplifying implementation of touchscreen support as camera movement

a7fc340

vitor251093 and others added 2 commits December 14, 2023 21:24

Merge pull request #49 from melonDS-emu/master

6666480

Updating base branch

Fixing conflict

3f9dbe6

nadiaholmquist force-pushed the master branch from 10c70eb to a7575ec Compare February 7, 2024 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing the use of the touchscreen as camera movement #1896

Implementing the use of the touchscreen as camera movement #1896

vitor251093 commented Nov 30, 2023

JesseTG Nov 30, 2023

vitor251093 Nov 30, 2023

JesseTG Nov 30, 2023

vitor251093 Dec 1, 2023 •

edited

vitor251093 Dec 2, 2023

JesseTG Dec 2, 2023

vitor251093 Dec 3, 2023

JesseTG Dec 2, 2023

vitor251093 Dec 3, 2023 •

edited

JesseTG Dec 3, 2023

RSDuck commented Dec 3, 2023

vitor251093 commented Dec 3, 2023 •

edited

CasualPokePlayer commented Dec 3, 2023 •

edited

JesseTG commented Dec 3, 2023

vitor251093 commented Dec 3, 2023 •

edited

vitor251093 commented Dec 5, 2023

vitor251093 commented Dec 15, 2023

Implementing the use of the touchscreen as camera movement #1896

Are you sure you want to change the base?

Implementing the use of the touchscreen as camera movement #1896

Conversation

vitor251093 commented Nov 30, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vitor251093 Dec 1, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vitor251093 Dec 3, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RSDuck commented Dec 3, 2023

vitor251093 commented Dec 3, 2023 • edited

CasualPokePlayer commented Dec 3, 2023 • edited

JesseTG commented Dec 3, 2023

vitor251093 commented Dec 3, 2023 • edited

vitor251093 commented Dec 5, 2023

vitor251093 commented Dec 15, 2023

vitor251093 Dec 1, 2023 •

edited

vitor251093 Dec 3, 2023 •

edited

vitor251093 commented Dec 3, 2023 •

edited

CasualPokePlayer commented Dec 3, 2023 •

edited

vitor251093 commented Dec 3, 2023 •

edited