Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghost-mode recipe #3900

Closed
wants to merge 1 commit into from
Closed

ghost-mode recipe #3900

wants to merge 1 commit into from

Conversation

javaguirre
Copy link
Contributor

@javaguirre javaguirre commented May 17, 2016

ghost-mode is a package to manage posts from your Ghost blog platform using its Rest API.

The package repository is in github.

I'm the creator and maintainer of the package.

Do I need to specify anything else?

Thank you! :-)

@purcell
Copy link
Member

purcell commented May 18, 2016

Thanks. Quick feedback:

  • This doesn't provide a mode, so please call it something like ghost or ghost-blog, rather than ghost-mode.
  • The advice around url-http-handle-authentication will not only affect requests made to the ghost API, so that is not good practice
  • Consider changing some of the defvar to defcustom.
  • Don't specify :files in the recipe please -- the default includes "*.el", which is fine here.

Hope that helps!

@javaguirre
Copy link
Contributor Author

Thank you @purcell! I'll do that! :-)

@javaguirre
Copy link
Contributor Author

I'm gonna create a new PR with the new package name and your suggested changes, I'll close this one.

@javaguirre javaguirre closed this May 26, 2016
@javaguirre javaguirre deleted the ghost-mode branch May 26, 2016 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants