Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paperless recipe #4557

Merged
merged 1 commit into from
Feb 11, 2017
Merged

Add paperless recipe #4557

merged 1 commit into from
Feb 11, 2017

Conversation

atgreen
Copy link
Contributor

@atgreen atgreen commented Feb 10, 2017

Brief summary of what the package does

Paperless is a major mode for sorting and filing PDF documents.

Direct link to the package repository

https://github.com/atgreen/paperless

Your association with the package

I am the author.

Relevant communications with the upstream package maintainer

None needed

Checklist

  • [*] I've read CONTRIBUTING.md
  • [*] I've used package-lint to check for packaging issues, and addressed its feedback
  • [*] I've built and installed the package using the instructions in the README

@syohex
Copy link
Contributor

syohex commented Feb 11, 2017

  • No package dependency header, f, s, cl-lib
  • Global variables should be declared by defvar, like paperless--table-contents, paperless--directory-list)
  • Customize variables should be declared by defcustom, like *paperless-root-dir*, *paperless-capture-dir*. And Emacs Lisp coding convention, * should not be used for global variable unlike common lisp
  • There are too many byte-compile warnings.

@atgreen
Copy link
Contributor Author

atgreen commented Feb 11, 2017

Thanks for the review @syohex. I've committed changes, and it should be good to go now.

@syohex syohex merged commit 921ba90 into melpa:master Feb 11, 2017
@syohex
Copy link
Contributor

syohex commented Feb 11, 2017

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants