Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recipes pocket-mode #4626

Merged
merged 1 commit into from Mar 19, 2017
Merged

add recipes pocket-mode #4626

merged 1 commit into from Mar 19, 2017

Conversation

lujun9972
Copy link
Contributor

Brief summary of what the package does

[Manage your pocket]

Direct link to the package repository

https://github.com/lujun9972/pocket-mode

Your association with the package

I am the maintainer

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

  • I've read CONTRIBUTING.md
  • I've used package-lint to check for packaging issues, and addressed its feedback
  • My elisp byte-compiles cleanly
  • M-x checkdoc is happy with my docstrings
  • I've built and installed the package using the instructions in the README

@syohex
Copy link
Contributor

syohex commented Mar 16, 2017

  • tabulated-list-print can accept only one optional argument on older Emacs(24.4, 24.5). This causes exception in pocket-refresh
  • I suppose list-pocket should be pocket-list for package naming convention.

@syohex syohex added the recipes label Mar 16, 2017
@lujun9972
Copy link
Contributor Author

The derived mode should also define a listing command. 
This, not the mode command, is what the user calls (e.g., M-x list-processes). 
The listing command should create or switch to a buffer, turn on the derived mode, specify the tabulated data, and finally call tabulated-list-print to populate the buffer. 

So I think list-pocket is the way following naming convention

@purcell
Copy link
Member

purcell commented Mar 19, 2017

pocket-list would still be preferable, please, and will not produce package-lint warnings.

In the meantime, I'll go ahead and merge this, which looks like a handy package!

@purcell purcell merged commit 6aa3d04 into melpa:master Mar 19, 2017
microamp pushed a commit to microamp/melpa that referenced this pull request Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants