Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bifocal recipe #4819

Merged
merged 1 commit into from Jun 25, 2017
Merged

Add bifocal recipe #4819

merged 1 commit into from Jun 25, 2017

Conversation

riscy
Copy link
Member

@riscy riscy commented Jun 24, 2017

Brief summary of what the package does

In bifocal-mode, paging up causes a comint-mode buffer to be split in two windows with a larger window on top (the head) and a smaller input window preserved on the bottom (the tail). This helps with monitoring new output and entering text at the prompt (in the tail window), while reviewing previous output (in the head window). Paging down all the way causes the split to disappear.

Direct link to the package repository

https://github.com/riscy/bifocal-mode

Your association with the package

Maintainer

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

  • I've read CONTRIBUTING.md
  • I've used package-lint to check for packaging issues, and addressed its feedback
  • My elisp byte-compiles cleanly
  • M-x checkdoc is happy with my docstrings
  • I've built and installed the package using the instructions in CONTRIBUTING.md

@purcell purcell merged commit 79e7199 into melpa:master Jun 25, 2017
@purcell
Copy link
Member

purcell commented Jun 25, 2017

Thanks. This is interesting.

BTW, the turn-on function in define-globalized-minor-mode doesn't need to be interactive. I feel like you could just define a regular global minor mode that adds/removes bifocal-mode from comint-mode-hook, since the current code causes the check to happen in every buffer.

@riscy
Copy link
Member Author

riscy commented Jun 25, 2017

Awesome, thank you for the feedback!

@riscy
Copy link
Member Author

riscy commented Jun 25, 2017

Following up -- I think just adding the turn-on to comint-mode-hook means the mode won't get turned [on] in existing buffers when someone calls bifocal-global-mode []. Thanks again. 👍

microamp pushed a commit to microamp/melpa that referenced this pull request Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants