Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alarm recipe. #4877

Closed
wants to merge 2 commits into from
Closed

Add alarm recipe. #4877

wants to merge 2 commits into from

Conversation

kevindragon
Copy link

Brief summary of what the package does

set or cancel an alarm

Direct link to the package repository

https://github.com/kevindragon/alerm.el

Your association with the package

maintainer

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

  • I've read CONTRIBUTING.md
  • I've used package-lint to check for packaging issues, and addressed its feedback
  • My elisp byte-compiles cleanly
  • M-x checkdoc is happy with my docstrings
  • I've built and installed the package using the instructions in CONTRIBUTING.md

@purcell
Copy link
Member

purcell commented Jul 29, 2017

Thanks for making your first MELPA submission!

This package has a few issues overall:

  • GPL license statement is missing
  • After setting a new alarm, you can't cancel a previous pending one
  • You should use interactive to prompt for the time in alarm-clock, rather than calling read-string yourself.
  • Hard-coding the playing of a sound isn't a good choice for many users: would be better to use something like the alert library to flexibly handle alerts.

Overall, the library has a very general name, and is currently tiny and not very widely useful, so I'd prefer not to accept it in its current form, sorry.

@purcell purcell closed this Jul 29, 2017
@kevindragon
Copy link
Author

kevindragon commented Aug 10, 2017

Thanks for reply.
This is my first contribute open source project. Although it is rejected, but I am still very happy, it will encourage me to learn more about open source and Emacs and Elisp, I will improve this package.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants