Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vdm-comint recipe #5807

Merged
merged 1 commit into from Nov 25, 2018
Merged

Add vdm-comint recipe #5807

merged 1 commit into from Nov 25, 2018

Conversation

peterwvj
Copy link
Contributor

Brief summary of what the package does

REPL support for vdm-mode.

Direct link to the package repository

https://github.com/peterwvj/vdm-mode

Your association with the package

I am the author and maintainer.

Relevant communications with the upstream package maintainer

None needed.

Checklist

Please confirm with x:

@purcell
Copy link
Member

purcell commented Nov 25, 2018

Thanks, looks good. Couple of suggestions:

  • The smartparens config snippet belongs in your personal emacs config. Having eval-after-load in library code is usually a smell, and can cause code to run at surprising times -- that macro is meant for use in configs, not libraries.
  • This progn is unneccessary.

In any case, I'll leave those with you and go ahead and merge this now. :-)

@purcell purcell merged commit 077f586 into melpa:master Nov 25, 2018
@peterwvj
Copy link
Contributor Author

Many thanks for your feedback, which is highly appreciated!

@purcell
Copy link
Member

purcell commented Nov 26, 2018

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants