Add the unobtrusive-magit-theme.

[tee3]

Brief summary of what the package does

This is an Emacs theme to improve the Magit faces in the case where a theme has not customized Magit faces. It is unobtrusive in that Magit fits better within a theme.

Direct link to the package repository

https://github.com/tee3/unobtrusive-magit-theme

Your association with the package

I am the author.

Relevant communications with the upstream package maintainer

The package-lint tool reports that the provide line is wrong, but this is a theme, so it uses provide-theme.

Checklist

Please confirm with x:

• The package is released under a GPL-Compatible Free Software License.
• I've read CONTRIBUTING.org
• I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
• My elisp byte-compiles cleanly
• M-x checkdoc is happy with my docstrings
• I've built and installed the package using the instructions in CONTRIBUTING.org
• I have confirmed some of these without doing them

[alphapapa]

Have you considered suggesting these changes be made in Magit itself?

[tee3]

I have not. I'll reach out and see what happens. Is that a blocker for getting this into MELPA? I could understand that, I'm just trying to understand the context for the question.

[tee3]

See magit/magit#4079

[alphapapa]

I am not MELPA, merely a fellow package author.

Is it a blocker? Well, if it makes more sense to put it in Magit, and if Jonas is amenable to that idea, then it wouldn't be necessary for this package to exist. I guess you could call that a blocker if you want. ;)

[tee3]

Understood thanks! It was a good suggestion so we’ll see what happens.

[riscy]

I'll mark this awaiting upstream so we can see what happens.

By the way, you can squash these kinds of package-lint warnings in theme files:

1 issue found:
1:0: error: There is no (provide 'unobtrusive-magit-theme) form.

...by ending the file with:

(provide-theme 'unobtrusive-magit)
(provide 'unobtrusive-magit-theme)
;;; unobtrusive-magit-theme.el ends here

[riscy]

(Feel free to ping if this isn't merged into magit and needs MELPA review.)

[tee3]

@riscy After discussions with @tarsius at magit/magit#4079, we've decided it makes to publish this package on MELPA with come caveats about potential breakage.

[riscy]

Awesome, thanks for following up on that. This looks good to merge too (although since you require Emacs 24.1, you can take advantage of lexical binding which is often a good idea).