Add flymake-phpstan package

[zonuexe]

Brief summary of what the package does

Flymake backend for PHP using PHPStan.

Direct link to the package repository

https://github.com/emacs-php/phpstan.el

Your association with the package

I'm the author.

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

• The package is released under a GPL-Compatible Free Software License.
• I've read CONTRIBUTING.org
• I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
• My elisp byte-compiles cleanly
• M-x checkdoc is happy with my docstrings
• I've built and installed the package using the instructions in CONTRIBUTING.org
• I have confirmed some of these without doing them

[riscy]

I'm seeing:

byte-compile-file (using Emacs 26.3):

flymake-phpstan.el:37:1:Error: Cannot open load file: No such file or directory, php-project

and can't see anywhere that php-project would be provided from?

Beyond that, just a small nag about the license:

• Use a LICENSE file that GitHub can detect (e.g. no markup).
  See: https://github.com/licensee/licensee

[zonuexe]

@riscy Thank you for your review.
I fixed. emacs-php/phpstan.el@7fda3bc emacs-php/phpstan.el@9345480

[riscy]

Thank you! Able to byte-compile now --

byte-compile-file (using Emacs 26.3):

flymake-phpstan.el:49:1:Warning: defcustom for
    `flymake-phpstan-disable-c-mode-hooks' fails to specify type
flymake-phpstan.el:49:1:Warning: defcustom for
    `flymake-phpstan-disable-c-mode-hooks' fails to specify type

I think you just want:type 'boolean per the available customization types.

After that this is an easy merge.

Some minor stuff:

• flymake-phpstan.el#L111: It's safer to sharp-quote function names; use #'
• executtable -> executable
• "Enable flymake-phpstan as buffer-local Flymake backend." -> "Enable `flymake-phpstan' as buffer-local Flymake backend."

[zonuexe]

@riscy Thank you, I fixed.

[riscy]

All good. :)