Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lsp-pyright #7045

Merged
merged 2 commits into from
Aug 8, 2020
Merged

Add lsp-pyright #7045

merged 2 commits into from
Aug 8, 2020

Conversation

zeronone
Copy link
Contributor

@zeronone zeronone commented Jul 26, 2020

Brief summary of what the package does

Python LSP client using Pyright LanguageServer

Direct link to the package repository

https://github.com/emacs-lsp/lsp-pyright

Your association with the package

Maintainer

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

  • The package is released under a GPL-Compatible Free Software License.
  • I've read CONTRIBUTING.org
  • I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
  • My elisp byte-compiles cleanly
  • M-x checkdoc is happy with my docstrings
  • I've built and installed the package using the instructions in CONTRIBUTING.org
  • I have confirmed some of these without doing them

@riscy
Copy link
Member

riscy commented Aug 1, 2020

Quick first pass.

lsp-pyright.el

byte-compile (using Emacs 26.3):

  • No issues!

checkdoc (using version 0.6.1):

Warning (emacs): 
lsp-pyright.el:59: First line is not a complete sentence
Warning (emacs): 
lsp-pyright.el:59: Some lines are over 80 columns wide
Warning (emacs): 
lsp-pyright.el:67: First line is not a complete sentence
Warning (emacs): 
lsp-pyright.el:95: First line is not a complete sentence
Warning (emacs): 
lsp-pyright.el:95: Some lines are over 80 columns wide
Warning (emacs): 
lsp-pyright.el:102: Some lines are over 80 columns wide
Warning (emacs): 
lsp-pyright.el:113: First sentence should end with punctuation
Warning (emacs): 
lsp-pyright.el:122: All variables and subroutines might as well have a documentation string
Warning (emacs): 
lsp-pyright.el:130: Argument `params' should appear (as PARAMS) in the doc string
Warning (emacs): 
lsp-pyright.el:135: All variables and subroutines might as well have a documentation string

package-lint (using version 20200616.2257):

  • No issues!

Suggestions/experimental static checks:

  • lsp-pyright.el#L25: Prefer https over http if possible (why?)

@zeronone
Copy link
Contributor Author

zeronone commented Aug 3, 2020

I have addressed above issues 🙇

@riscy
Copy link
Member

riscy commented Aug 8, 2020

Great, thanks! I had the privilege to chat with the first author of pyright a while ago, this is cool to see.

@riscy riscy merged commit 42a1aee into melpa:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants