Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for germanium #7696

Merged
merged 1 commit into from Aug 29, 2021
Merged

Add recipe for germanium #7696

merged 1 commit into from Aug 29, 2021

Conversation

matsuyoshi30
Copy link
Contributor

Brief summary of what the package does

Tool for generating an image from source code using germanium.

Package users can generate an image from a buffer or region.

Direct link to the package repository

https://github.com/matsuyoshi30/germanium-el

Your association with the package

Author, maintainer

Relevant communications with the upstream package maintainer

None needed

Checklist

  • The package is released under a GPL-Compatible Free Software License
  • I've read CONTRIBUTING.org
  • I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
  • My elisp byte-compiles cleanly
  • M-x checkdoc is happy with my docstrings
  • I've built and installed the package using the instructions in CONTRIBUTING.org
  • I have confirmed some of these without doing them

@riscy
Copy link
Member

riscy commented Aug 29, 2021

Thanks for your close adherence for the checklist, and great work taking care of shell-quoting the arguments.

Minor lints, but none of these are blockers:

  • germanium.el#L134: This double negation can be collapsed (not aliases null)
  • On a quick first pass, I think most of the errors could be turned into user-errors
  • "Please ensure Emacs's PATH and the installing" -> "Please ensure it is on Emacs's PATH and is installed"

@riscy riscy merged commit 6cc5983 into melpa:master Aug 29, 2021
@matsuyoshi30 matsuyoshi30 deleted the germanium branch August 30, 2021 01:39
@matsuyoshi30 matsuyoshi30 restored the germanium branch August 30, 2021 01:39
@matsuyoshi30 matsuyoshi30 deleted the germanium branch August 30, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants