New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for eshell-info-banner #7790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for this! Quick first pass below -- byte-compile (using Emacs 27.1):
checkdoc (using version 0.6.2):
package-lint (using version 20211107.1614):
|
Phundrak
added a commit
to Phundrak/eshell-info-banner.el
that referenced
this pull request
Nov 8, 2021
Fix byte-compile and package-lint errors as mentionned here melpa/melpa#7790 (comment) Fix a docstring that was too long, quoted `eshell-info-banner' in three other docstrings. Renaming functions may have introduced some breaking changes, hence the update on the REAME. Since these were breaking changes, this commit removes two functions as well which weren’t used internally anymore.
Phundrak
added a commit
to Phundrak/eshell-info-banner.el
that referenced
this pull request
Nov 8, 2021
Fix byte-compile and package-lint errors as mentionned here melpa/melpa#7790 (comment) Fix a docstring that was too long, quoted `eshell-info-banner' in three other docstrings. Renaming functions may have introduced some breaking changes, hence the update on the REAME. Since these were breaking changes, this commit removes two functions as well which weren’t used internally anymore.
Thank you for your review, these issues are now fixed in the latest commit
<Phundrak/eshell-info-banner.el@36d1b98>
…--
Lucien “Phundrak” Cartier-Tilet
<https://phundrak.com> (Français)
<https://phundrak.com/en> (English)
Sent from GNU/Emacs
|
Looks good, thanks again. Welcome to MELPA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of what the package does
eshell-info-banner.el is a package that customizes the eshell banner
so it displays information on the system, such as the system’s name,
mounted partitions, and memory usage.
Direct link to the package repository
https://github.com/Phundrak/eshell-info-banner.el
Your association with the package
I am the creator and maintainer of eshell-info-banner.el
Checklist
M-x checkdoc
is happy with my docstrings