Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for eshell-info-banner #7790

Merged
merged 1 commit into from Nov 13, 2021
Merged

Add recipe for eshell-info-banner #7790

merged 1 commit into from Nov 13, 2021

Conversation

Phundrak
Copy link
Contributor

@Phundrak Phundrak commented Nov 6, 2021


Brief summary of what the package does

eshell-info-banner.el is a package that customizes the eshell banner
so it displays information on the system, such as the system’s name,
mounted partitions, and memory usage.

Direct link to the package repository

https://github.com/Phundrak/eshell-info-banner.el

Your association with the package

I am the creator and maintainer of eshell-info-banner.el

Checklist

  • The package is released under a GPL-Compatible Free Software License
  • I've read CONTRIBUTING.org
  • I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
  • My elisp byte-compiles cleanly
  • M-x checkdoc is happy with my docstrings
  • I've built and installed the package using the instructions in CONTRIBUTING.org
  • I have confirmed some of these without doing them

@riscy
Copy link
Member

riscy commented Nov 8, 2021

Thanks for this! Quick first pass below --

byte-compile (using Emacs 27.1):

eshell-info-banner.el:51:1:Warning: defgroup for `eshell-info-banner' fails to
    specify containing group
eshell-info-banner.el:695:1:Warning: Unused lexical variable `os'

checkdoc (using version 0.6.2):

  • No issues!

package-lint (using version 20211107.1614):

17 issues found:
51:0: error: Customization groups should specify a parent via `:group'.
208:16: error: You should depend on (emacs "25.1") or the seq package if you need `seq-some'.
266:0: error: `eshell-info-banner--get-mounted-partitions/duf' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
277:46: error: You should depend on (emacs "25.1") or the seq package if you need `seq-some'.
280:42: error: You should depend on (emacs "25.1") or the seq package if you need `seq-into-sequence'.
295:0: error: `eshell-info-banner--get-mounted-partitions/df' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
311:22: error: You should depend on (emacs "25.1") or the seq package if you need `seq-some'.
324:0: error: `eshell-info-banner--get-mounted-partitions/gnu' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
332:0: error: `eshell-info-banner--get-mounted-partitions/windows' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
342:0: error: `eshell-info-banner--get-mounted-partitions/darwin' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
400:0: error: `eshell-info-banner--get-memory/gnu' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
411:0: error: `eshell-info-banner--get-memory/unix' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
427:0: error: `eshell-info-banner--get-memory/darwin' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
455:0: error: `eshell-info-banner--get-memory/windows' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
639:0: error: `eshell-info-banner--get-os-information/windows' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
652:0: error: `eshell-info-banner--get-os-information/gnu' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
689:0: error: `eshell-info-banner--get-os-information/darwin' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).

Phundrak added a commit to Phundrak/eshell-info-banner.el that referenced this pull request Nov 8, 2021
Fix byte-compile and package-lint errors as mentionned here
melpa/melpa#7790 (comment)

Fix a docstring that was too long, quoted `eshell-info-banner' in
three other docstrings.

Renaming functions may have introduced some breaking changes, hence
the update on the REAME. Since these were breaking changes, this
commit removes two functions as well which weren’t used internally
anymore.
Phundrak added a commit to Phundrak/eshell-info-banner.el that referenced this pull request Nov 8, 2021
Fix byte-compile and package-lint errors as mentionned here
melpa/melpa#7790 (comment)

Fix a docstring that was too long, quoted `eshell-info-banner' in
three other docstrings.

Renaming functions may have introduced some breaking changes, hence
the update on the REAME. Since these were breaking changes, this
commit removes two functions as well which weren’t used internally
anymore.
@Phundrak
Copy link
Contributor Author

Phundrak commented Nov 8, 2021 via email

@riscy
Copy link
Member

riscy commented Nov 13, 2021

Looks good, thanks again. Welcome to MELPA!

@riscy riscy merged commit d602d15 into melpa:master Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants