Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for flycheck-eglot #8382

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Add recipe for flycheck-eglot #8382

merged 1 commit into from
Feb 5, 2023

Conversation

intramurz
Copy link
Contributor

Brief summary of what the package does

A simple "glue" minor mode that allows Flycheck and Eglot to work together.

Direct link to the package repository

https://github.com/intramurz/flycheck-eglot

Your association with the package

Author and Maintainer

Relevant communications with the upstream package maintainer

None needed

Checklist

@progfolio
Copy link
Member

Is it possible to achieve what you're trying to do without relying on the internal functions/variables of your dependencies? I noticed you directly rely on the following symbols:

flymake--diag-locus 
flymake--diag-beg 
flymake--diag-text 
flymake--diag-end 
flycheck--automatically-disabled-checkers
flycheck--automatically-enabled-checkers

For at least flycheck--automatically-disabled-checkers, its docstring mentions:

To trigger a reverification from Emacs Lisp code, do not modify
this variable: use `flycheck-reset-enabled-checker'

It's best to avoid using these private symbols because the author of the package does not intend for them to be part of the API.

@intramurz
Copy link
Contributor Author

Thank you very much! Your review has been very helpful. Made corrections.

Public accessors for flymake--diag are created with a macro, slightly confusing

@riscy
Copy link
Member

riscy commented Feb 5, 2023

This is solidly written. Thanks both - and welcome to MELPA, @intramurz!

@riscy riscy merged commit ead6dff into melpa:master Feb 5, 2023
@intramurz intramurz deleted the add-flycheck-eglot-recipe branch February 6, 2023 00:08
akirak pushed a commit to akirak/melpa that referenced this pull request Jul 8, 2023
@intramurz intramurz restored the add-flycheck-eglot-recipe branch February 18, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants