Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for company-protobuf #8923

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weidaolee
Copy link

Brief summary of what the package does

Add Protobuf directives keywords to company-mode keywords alist.

Direct link to the package repository

https://github.com/weidaolee/company-protobuf

Your association with the package

maintainer

Relevant communications with the upstream package maintainer

None needed

Checklist

@weidaolee weidaolee changed the title Add recipes company-protobuf Add recipe for company-protobuf Feb 17, 2024
@riscy
Copy link
Member

riscy commented Feb 18, 2024

Thanks for this. Quick first pass --

company-protobuf.el with byte-compile using Emacs 29.1:

company-protobuf.el:46:11: Warning: Package cl is deprecated
company-protobuf.el:47:2: Error: Cannot open load file: No such file or directory, company

Looks like a missing Package-Requires on company.

company-protobuf.el with checkdoc 0.6.2 (fix within reason):

company-protobuf.el:80: Argument `command' should appear (as COMMAND) in the doc string

company-protobuf.el with package-lint 20240214.1423:

6 issues found:
1:0: warning: The package summary should start with an uppercase letter or a digit.
4:35: warning: Use a properly versioned dependency on "cl-lib" if possible.
4:42: warning: Use a properly versioned dependency on "company" if possible.
6:3: warning: You should include standard keywords: see the variable `finder-known-keywords'.
13:0: error: Package should have a non-empty ;;; Commentary section.
76:4: warning: Closing parens should not be wrapped onto new lines.

Package and license:

  • Use :fetcher github :repo <repo> instead of :url
  • company-protobuf.el needs formal license boilerplate and/or an SPDX-License-Identifier

@riscy riscy added the awaiting-upstream Awaiting action from an upstream maintainer label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream Awaiting action from an upstream maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants