Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added semver recipe #8932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Etenil
Copy link

@Etenil Etenil commented Feb 21, 2024

Brief summary of what the package does

Semver parses a version constraint string and echoes the version range that matches. Going from ^1.1.0 to >=1.1.0 <2.0.0 for example. This is useful to verify the correct string was written.

Direct link to the package repository

https://gitlab.com/binary-ec/semver.el

Your association with the package

I am the author and maintainer of the package.

Relevant communications with the upstream package maintainer

None needed

Checklist

@progfolio
Copy link
Contributor

Unfortunately, I did not have to do detailed notes on this.
I did publish a gist with some changes that I would suggest:

https://gist.github.com/progfolio/2e95b1e3ba53116a40b01a08be20a26e

Feel free to use anything in there if you like.

@Etenil
Copy link
Author

Etenil commented Mar 1, 2024

Thanks a lot @progfolio, this looks good. I'll make some tweaks and update.

@riscy
Copy link
Member

riscy commented Mar 2, 2024

Thanks both. Here's a quick first pass from my side, too --

semver.el with package-lint 20240220.2303:

5 issues found:
1:0: warning: "Version:" or "Package-Version:" header is missing. MELPA will handle this, but other archives will not.
1:0: warning: Including "Emacs" in the package summary is usually redundant.
1:51: warning: You should depend on (emacs "24.1") if you need lexical-binding.
6:3: warning: You should include standard keywords: see the variable `finder-known-keywords'.
85:9: warning: Closing parens should not be wrapped onto new lines.

Package and license:

  • Prefer equivalent recipe: (semver :repo "binary-ec/semver.el" :fetcher gitlab)

@riscy riscy added the awaiting-upstream Awaiting action from an upstream maintainer label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream Awaiting action from an upstream maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants