Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add org-clock-agenda-daytime-mode #8937

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

ArneBab
Copy link
Contributor

@ArneBab ArneBab commented Feb 24, 2024

Brief summary of what the package does

display the time clocked today in the modeline

Direct link to the package repository

https://github.com/ArneBab/emacs-org-clock-daytime

Your association with the package

Creator

Relevant communications with the upstream package maintainer

None needed

Checklist

@riscy
Copy link
Member

riscy commented Mar 2, 2024

Thanks for this. Quick first pass --

org-clock-agenda-daytime-mode.el with package-lint 20240220.2303:

10 issues found:
1:0: error: Package should have a Homepage or URL header.
1:0: error: package.el cannot parse this buffer: Package lacks a file header
1:89: warning: You should depend on (emacs "24.1") if you need lexical-binding.
37:0: error: "org-total-time--last-time" doesn't start with package's prefix "org-clock-agenda-daytime".
38:0: error: "org-total-time--last-res" doesn't start with package's prefix "org-clock-agenda-daytime".
41:10: error: You should depend on (emacs "24.1") if you need `org'.
42:0: error: "org-total-time" doesn't start with package's prefix "org-clock-agenda-daytime".
51:21: error: You should depend on (emacs "26.1") if you need `org-duration-from-minutes'.
56:37: error: You should depend on (emacs "24.3") if you need `org-clock-sum-today'.
60:0: error: Global minor modes should be autoloaded or, rarely, `:require' their defining file (i.e. ":require 'org-clock-agenda-daytime-mode"), to support the customization variable of the same name.

org-clock-agenda-daytime-mode.el with melpazoid:

- org-clock-agenda-daytime-mode.el#L52: It's safer to sharp-quote function names; use `#'`

@ArneBab
Copy link
Contributor Author

ArneBab commented Mar 3, 2024

Thank you for checking! I doublechecked my linting here and found I had used use-package-lint instead … (I’m sorry about that). The most recent commit should fix the issues.

Regarding melpazoid: did this run on the most recent code? I’m already using #'+ in apply.

@riscy
Copy link
Member

riscy commented Mar 10, 2024

Regarding melpazoid

Some of those sharp-quote nags occasionally throw false positives and I have to double-check them by hand. But the version of the code I am checking right now (your latest) is not throwing any of them.

In any case, thanks for this - merging. :)

@riscy riscy merged commit d86e8d1 into melpa:master Mar 10, 2024
1 check passed
@ArneBab
Copy link
Contributor Author

ArneBab commented Mar 10, 2024

Thank you for merging — and doubled for maintaining melpa!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants