-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for dumber-jump #9065
base: master
Are you sure you want to change the base?
Conversation
I think you will need to rename the symbols to FYI for help ensuring clean compilation, etc, you might try https://github.com/alphapapa/makem.sh (see also its |
@alphapapa I don't think you're looking at the branch I'm publishing: https://github.com/zenspider/dumber-jump/tree/dumber-jump |
I'd guess that you should merge that to your master branch, then. Otherwise visitors to your repo will see an old commit from an old fork. It's awkward for the name of the repo to have changed, but the master branch to represent a different repo. Alternatively, start a new repo that GitHub doesn't consider a fork; it's not necessary for GitHub to recognize it as one, anyway. |
I assume visitors visiting via melpa click the github link and it goes to the branch, no? I'd like to maintain upstream in order to rebase (if they ever commit anything again). Suggestions welcome. |
I can only say, again, that it would be awkward for the URL https://github.com/zenspider/dumber-jump to actually point to a clone of
You needn't have your clone's Note as well that you should not be rebasing your package's master branch (whether it's named The rule of thumb is to never rebase a published |
I agree with @alphapapa here, and usually "such an arrangement would be very unusual and likely to confuse" is the best litmus test. The default branch shouldn't exist solely to be a fork-point (if I'm understanding correctly). Here's some quick feedback from the lints, but note that checkdoc is considered within reason these days. Checkdoc does check some crucial stuff, so be sure you check.
|
Friendly ping. :) |
Brief summary of what the package does
Dumber Jump is a fork from dumb-jump that removes as many
configuration options as possible to go back to the roots of being a
fairly config-free "dumb" jump. This version doesn't support other
searchers, doesn't support alternative display methods, and only
interfaces through xref.
Note: while this package is a "fork", it is a massive divergence at
this point:
byte-compile is mostly complaining about 80 char widths at this point.
checkdoc... ugh. this tool. working on it.
Direct link to the package repository
https://github.com/zenspider/dumber-jump/tree/dumber-jump
Your association with the package
I am the maintainer (of this fork)
Relevant communications with the upstream package maintainer
None needed
Checklist
M-x checkdoc
to check the package's documentation strings