Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy files for multi-file packages as individuals, #98

Merged
merged 1 commit into from
Apr 30, 2012
Merged

Conversation

milkypostman
Copy link
Member

rather than duplicating the repository.

@purcell
Copy link
Member

purcell commented Apr 30, 2012

Yeah, this basically looks good. I've a suspicion that some recipes expect to have subdirectories full of data files etc.

@purcell
Copy link
Member

purcell commented Apr 30, 2012

I think basedir might be unnecessary. Here's an idea: if all the :files patterns expand to files within the same directory, then that must be the basedir. So if you expand all the :files, you can look for the closest common parent directory, and tar up files relative to that.

@milkypostman
Copy link
Member Author

Yes, that is a great idea. OR the shortest path to any file in the files list. Because technically there needs to be some file in the root directory.

OK, let me have another day at this. I'm going to go finish some grading first and then I'll give this some treatment in the afternoon.

@purcell
Copy link
Member

purcell commented Apr 30, 2012

Yes, I think that's sort of how I saw it working in my head. :-)

@milkypostman milkypostman merged commit abbe137 into master Apr 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants