New MWDA error in host

[tedinski]

Errors for edu:umn:cs:melt:ableC:abstractsyntax
 [edu.umn.cs.melt.ableC/abstractsyntax/Decls.sv]
Decls.sv:322:87: warning: Attribute section (.pp) requires attributes not know to be on 'SpecialSpecifier': env, returnType

This was a missing and recently introduced check in the Silver MWDA.

[krame505]

Also the typo in that error message should get fixed...

…

On Jul 11, 2017 10:59 AM, "Ted Kaminski" ***@***.***> wrote: Errors for edu:umn:cs:melt:ableC:abstractsyntax [edu.umn.cs.melt.ableC/abstractsyntax/Decls.sv] Decls.sv:322:87: warning: Attribute section (.pp) requires attributes not know to be on 'SpecialSpecifier': env, returnType This was a missing and recently introduced check in the Silver MWDA. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#53>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIE1ilcf7_Say77rufIAEX2I94A-S4XGks5sM5u7gaJpZM4OUdGs> .

[krame505]

After a little poking, it seems that there are a large number of flow problems related to pp and a few other attributes that just haven't yet caused any problems. I am going to go ahead and add explicit flowtypes for almost everything in ableC, which should (hopefully) finally pin these down for good, and also allow for the removal of all of our 'hackUnused' productions.

[ericvanwyk]

@tedinski - is there a status page somewhere the lists missing or incomplete parts of the MWDA? Can you create one otherwise?

@krame505 - thanks. It would be great to get this sorted out.

[tedinski]

We have a tag for all flow analysis related issues: https://github.com/melt-umn/silver/issues?q=is%3Aissue+is%3Aopen+label%3AFlowAnalysis

The only missing thing should be the improvement I want to make to pattern matching. (Which shouldn't be anything missing, just an improvement?)

I started a "silver 0.4 release" project to track what I want to get done: https://github.com/melt-umn/silver/projects/3

[ericvanwyk]

With attribute sections, (.pp) for example, do these assume that the tree they are applied to is decorated? Is this why the MWDA now raises this error? We don't need env and returnType to compute pp.

I've fixed this (in #58), though there are additional things (as Lucas mentions) to be done.

[krame505]

Attribute sections can be applied to a decorated nonterminal or to an undecorated nonterminal, in which case it is implicitly decorated with no inherited attributes. The MWDA error is because something is messing up the flowtype on Expr for pp and causing it to depend on env and returnType anyway - this will be fixed as part of my flowtype audit, accessing pp via attribute section on an undecorated nonterminal is supposed to be OK.
This is only showing up now because Ted just recently implemented flowtype checking on attribute sections, the Expr flowtype issue on pp has probably been around for a while.

[krame505]

Fixed by #60