Fix/mwda special specifiers

[TravisCarlson]

This addresses issues #53 and #54 by creating a SpecialSpecifiers nonterminal to be used in place of [SpecialSpecifier] and adding --warn-error in the Jenkinsfile.

Would it be worth changing the signature of functionDecl rather than creating a local specialSpecifiers? See the TODO comment.

Jenkins seems to have a problem with mkdir on new branches. I've created issue #57 for this.

[krame505]

`env` and `returnType` shouldn't even be needed for `pp` in the first place, so this is just a sign of deeper problems. I am in the middle of a full audit of ableC flowtypes (waiting on a change to flowtype specs ATM) that should fix this. I'm not opposed to also making a `SpecialSpecifiers` nonterminal, but we should change the `functionDecl` signature as well if we do make this change. Bare in mind that this will break almost every extension... On Aug 1, 2017 3:02 PM, "Travis Carlson" <notifications@github.com> wrote: This addresses issues #53 <#53> and #54 <#54> by creating a SpecialSpecifiers nonterminal to be used in place of [SpecialSpecifier] and adding --warn-error in the Jenkinsfile. Would it be worth changing the signature of functionDecl rather than creating a local specialSpecifiers? See the TODO comment. Jenkins seems to have a problem with mkdir on new branches. I've created issue #57 <#57> for this. ------------------------------ You can view, comment on, or merge this pull request online at: #58 Commit Summary - added SpecialSpecifiers to treat inh attrs properly - adding --warn-error to to catch, at least, MWDA problems on host - update sqlite name - debug jenkins mkdir generated - change ableC-cilk branch from master to develop File Changes - *M* Jenkinsfile <https://github.com/melt-umn/ableC/pull/58/files#diff-0> (15) - *M* edu.umn.cs.melt.ableC/abstractsyntax/Decls.sv <https://github.com/melt-umn/ableC/pull/58/files#diff-1> (22) - *M* edu.umn.cs.melt.ableC/abstractsyntax/TypeQualifiers.sv <https://github.com/melt-umn/ableC/pull/58/files#diff-2> (35) Patch Links: - https://github.com/melt-umn/ableC/pull/58.patch - https://github.com/melt-umn/ableC/pull/58.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#58>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIE1irlk4MlEPb5m3Jlg8YNJFkGp59JUks5sT4Q-gaJpZM4OqOHN> .

[ericvanwyk]

Yes, I agree that we should change the signature of functionDecl.

Do the changes to other synthesized attributes (globalDefs or defs) look right as they are now?

[krame505]

Yes, this looks fine otherwise.

[ericvanwyk]

OK, I've changed the signatures and all the extensions I can find that it affects. Merging.

[tedinski]

Just a general comment now that I'm looking through my github notifications at the moment:

Basically anyplace I've used a [List] in the signature of a production in the AST was me being lazy. They're all just waiting for the right thing to come along and cause problems. I just didn't want to get around to writing out a boilerplate list nonterminal for them yet, and then never got around to it and here we are.

The need for list nonterminals is something that someone should someday think about. :) I suspect they're unavoidable, but maybe we could add some sugar for helping deal with them somehow. (Even if it's just a quick way to generate them or something.)