Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quality attribute - Part 2 #1347

Merged
merged 18 commits into from
May 26, 2023
Merged

Add quality attribute - Part 2 #1347

merged 18 commits into from
May 26, 2023

Conversation

pnadolny13
Copy link
Contributor

Relates to #1346

@pnadolny13 pnadolny13 changed the title Add quality attribute part2 Add quality attribute - Part 2 May 24, 2023
@tayloramurphy
Copy link
Collaborator

@pnadolny13 can we pull this into a spreadsheet to look at? I can't get the diff to load without crashing my window.

I also think we should set some minimum overrides depending on the maintainer. singer-io and airbyte in particular come to mind.

Base automatically changed from add_quality_attribute to main May 25, 2023 14:32
@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 16:25 — with GitHub Actions Inactive
@netlify
Copy link

netlify bot commented May 25, 2023

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit 0201390
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/6470b9d0b777120008507e2e
😎 Deploy Preview https://deploy-preview-1347--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 16:27 — with GitHub Actions Inactive
@pnadolny13
Copy link
Contributor Author

@tayloramurphy its probably easiest to iterate using the spreadsheet in https://github.com/pnadolny13/hub-utils/pull/45#issuecomment-1563233207 then once we're happy I'll propagate the change to this PR.

I also updated this to only include and require quality for extractors/loaders instead of all plugins like I did before. Let me know if you were thinking differently though!

@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 20:39 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 20:40 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 20:46 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 20:49 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 20:49 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 20:51 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 21:22 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 21:24 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 21:49 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 21:50 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 21:58 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 enabled auto-merge (squash) May 25, 2023 21:58
@pnadolny13 pnadolny13 disabled auto-merge May 25, 2023 21:58
@pnadolny13 pnadolny13 temporarily deployed to preview May 25, 2023 22:00 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 26, 2023 13:41 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 26, 2023 13:42 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 26, 2023 13:53 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 26, 2023 13:55 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 merged commit 630d7e0 into main May 26, 2023
11 checks passed
@pnadolny13 pnadolny13 deleted the add_quality_attribute_part2 branch May 26, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants