Skip to content

Commit

Permalink
Merge branch 'main' into 2089-just-in-time-install
Browse files Browse the repository at this point in the history
  • Loading branch information
ReubenFrankel committed May 24, 2024
2 parents 6fb26f6 + 32d0893 commit edc1cd0
Show file tree
Hide file tree
Showing 25 changed files with 272 additions and 207 deletions.
8 changes: 4 additions & 4 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,18 @@

# Default owners

- @edgarrmondragon @WillDaSilva
* @edgarrmondragon @WillDaSilva

# CI
.github/actions/ @WillDaSilva @meltano/engineering
.github/workflows/ @WillDaSilva @meltano/engineering

# Docs (General)
/docs/ @sbalnojan @tayloramurphy @meltano/engineering @meltano/marketing
/README.md @sbalnojan @tayloramurphy @meltano/engineering @meltano/marketing
/docs/ @tayloramurphy @meltano/engineering @meltano/marketing
/README.md @tayloramurphy @meltano/engineering @meltano/marketing

# Docs (Contributing)
/CONTRIBUTING.md @sbalnojan @tayloramurphy @meltano/engineering
/CONTRIBUTING.md @tayloramurphy @meltano/engineering

# Integration tests
/docs/example-library/ @meltano/product @meltano/engineering
Expand Down
14 changes: 7 additions & 7 deletions .github/actions/docker-build-scan-push/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ runs:
using: 'composite'
steps:
- name: Set up QEMU
uses: docker/setup-qemu-action@v2
uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3

- name: Prepare the tags
id: prepare-tags
Expand All @@ -43,7 +43,7 @@ runs:
echo "tags=$(echo "${{ inputs.tags }}" | sed "s/^/${{ inputs.registry }}\/meltano\/meltano:/" | tr '\n' ',')" >> $GITHUB_OUTPUT
- name: Build the image for all supported architectures
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: docker/meltano
build-args: |
Expand All @@ -60,7 +60,7 @@ runs:
push: false

- name: Load the amd64 image for scanning
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: docker/meltano
build-args: |
Expand All @@ -87,7 +87,7 @@ runs:
severity-cutoff: "critical"

- name: Upload Anchore scan SARIF report
uses: github/codeql-action/upload-sarif@v2
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: ${{ steps.anchore-scan.outputs.sarif }}
category: python-${{ inputs.python-version }}
Expand All @@ -105,15 +105,15 @@ runs:
[ "$NUM_ISSUES" = '0' ] # Error if there are any alerts that are neither fixed nor dismissed
- name: Login to the registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ${{ inputs.registry }}
username: ${{ inputs.username }}
password: ${{ inputs.password }}

- name: Push the scanned image to the registry
if: ${{ inputs.push == 'true' }}
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: docker/meltano
build-args: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

steps:
- name: Check out the repository
uses: actions/checkout@v4.1.4
uses: actions/checkout@v4.1.6

- name: Install Poetry
env:
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
environment: publishing
steps:
- name: Check out the repository
uses: actions/checkout@v4.1.4
uses: actions/checkout@v4.1.6

- name: Download artifacts
uses: actions/download-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4.1.4
uses: actions/checkout@v4.1.6

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dependency-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout the repository
uses: actions/checkout@v4.1.4
uses: actions/checkout@v4.1.6

- name: GitHub dependency vulnerability check
if: ${{ github.event_name == 'pull_request_target' }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
echo "dry_run=${{ format('{0}', github.event.inputs.dry_run) || env.DEFAULT_DRY_RUN }}" >> $GITHUB_ENV
echo "registry=${{ github.event.inputs.registry || env.DEFAULT_REGISTRY }}" >> $GITHUB_ENV
- uses: actions/checkout@v4.1.4
- uses: actions/checkout@v4.1.6

- name: Get Meltano version
id: get-meltano-version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out the repository
uses: actions/checkout@v4.1.4
uses: actions/checkout@v4.1.6

- name: Install Poetry
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint_snowplow_schemas.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout the repository
uses: actions/checkout@v4.1.4
uses: actions/checkout@v4.1.6

- name: Iglu Schema Lint
uses: ./.github/actions/igluctl-lint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/resources/constraints.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
nox==2024.4.15
nox-poetry==1.0.3
pip==24.0
poetry==1.8.2
poetry==1.8.3
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:

steps:
- name: Check out the repository
uses: actions/checkout@v4.1.4
uses: actions/checkout@v4.1.6

- name: Install Poetry
env:
Expand Down Expand Up @@ -247,7 +247,7 @@ jobs:
needs: tests
steps:
- name: Check out the repository
uses: actions/checkout@v4.1.4
uses: actions/checkout@v4.1.6

- name: Install Poetry
env:
Expand Down Expand Up @@ -292,7 +292,7 @@ jobs:
fail_ci_if_error: true
files: ./coverage.xml
token: ${{ secrets.CODECOV_TOKEN }}
uses: codecov/codecov-action@v4.3.1
uses: codecov/codecov-action@v4.4.0

mypy:
name: "Static type checking"
Expand All @@ -302,7 +302,7 @@ jobs:

steps:
- name: Check out the repository
uses: actions/checkout@v4.1.4
uses: actions/checkout@v4.1.6

- name: Install Poetry
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/version_bump.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
pull-requests: write # to create and update PRs

steps:
- uses: actions/checkout@v4.1.4
- uses: actions/checkout@v4.1.6
with:
fetch-depth: 0

Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ repos:
- id: debug-statements

- repo: https://github.com/python-jsonschema/check-jsonschema
rev: 0.28.2
rev: 0.28.4
hooks:
- id: check-metaschema
name: validate JSON schemas against meta schemas
Expand Down Expand Up @@ -74,7 +74,7 @@ repos:
- "prettier@3.0.0"

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.4.3
rev: v0.4.4
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix, --show-fixes]
Expand Down
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,18 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/) and [Keep a Changelog](http://keepachangelog.com/).

## v3.4.2 (2024-05-15)

### 🐛 Fixes

- [#8542](https://github.com/meltano/meltano/issues/8542) State from interrupted pipelines or using the `--merge-state` flag no longer causes crashes

### 📚 Documentation Improvements

- [#8544](https://github.com/meltano/meltano/issues/8544) Added YAML docs examples of global and per-plugin `python` executable option

## v3.4.1 (2024-05-06)

## v3.4.1b1 (2024-05-06)

### 🐛 Fixes
Expand Down
2 changes: 2 additions & 0 deletions docs/docs/reference/command-line-interface.md
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ Then regardless of the Python version used when the plugin is installed, `tap-gi

- `--force-install`: Ignore the required Python version declared by the plugins.

- `--python`: The Python version to use for the plugin. See [the setting documentation](/reference/settings#python) for more information.

### Using `add` with Environments

The `add` command does not run relative to a [Meltano Environment](https://docs.meltano.com/concepts/environments). The `--environment` flag and [`default_environment` setting](https://docs.meltano.com/concepts/environments#default-environments) in your `meltano.yml` file will be ignored if set.
Expand Down
25 changes: 24 additions & 1 deletion docs/docs/reference/settings.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,28 @@ to list all available settings with their names, environment variables, and curr

### <a name="plugin-python"></a>`python`

The python version to use for this plugin, specified as a path, or as the name of an executable to find within a directory in `$PATH`.
The python version to use for this plugin, specified as a path, or as the name of an executable to find within a directory in `$PATH`. You can set it at the time you add a plugin using [`meltano add --python <python>`](/reference/command-line-interface#add).

If not specified, [the top-level `python` setting will be used](#project-python), or if it is not set, the python executable that was used to run Meltano will be used (within a separate virtual environment).

This setting only applies when creating new virtual environments. If you've already created a virtual environment and you'd like to use a new Python version for it, you'll need to delete it from within `.meltano/`, then run `meltano install` for that plugin again.

This setting only applies to base plugins, which have their own virtual environment. Inherited plugins necessarily use the same virtual environment (and thus, the Python version) as their base plugin.

Example:

```yaml
plugins:
extractors:
- name: tap-gitlab
variant: meltanolabs
python: /path/to/python3.10
loaders:
- name: target-postgres
variant: meltanolabs
python: python3.10 # if it's in your $PATH
```

## Your Meltano project

These are settings specific to [your Meltano project](/concepts/project).
Expand All @@ -57,6 +71,15 @@ This setting only applies when creating new virtual environments. If you've alre

This setting only applies to base plugins, which have their own virtual environment. Inherited plugins necessarily use the same virtual environment (and thus, the Python version) as their base plugin.

Example:

```yaml
python: /path/to/python3.10 # or just python3.10 if it's in your $PATH
plugins:
extractors: ...
loaders: ...
```

### <a name="send_anonymous_usage_stats"></a>`send_anonymous_usage_stats`

- [Environment variable](../guide/configuration#configuring-settings): `MELTANO_SEND_ANONYMOUS_USAGE_STATS`
Expand Down
3 changes: 2 additions & 1 deletion docs/docusaurus.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -207,9 +207,10 @@ const config = {
hideable: true,
},
},
// https://www.docusaurus.io/docs/search
algolia: {
appId: 'RH6DR0I7R7',
apiKey: '44af7e07962ccb69a33accdb699d3347',
apiKey: '6d3c8732a3b6feb9fdae6de7b68de90e',
indexName: 'meltanodocs',
// contextualSearch: true,
// searchParameters: {},
Expand Down
2 changes: 1 addition & 1 deletion docs/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "docs.meltano.com",
"license": "MIT",
"version": "3.4.1",
"version": "3.4.2",
"description": "https://meltano.com",
"private": true,
"scripts": {
Expand Down
Loading

0 comments on commit edc1cd0

Please sign in to comment.