New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add env
as first-class attribute of MeltanoFile
and ProjectPlugin
classes (not an extra
)
#6207
Labels
Comments
@kgpayne Is this the idea? just putting some lame pseudo-code yaml to illustrate the question env:
DATABASE: COOL_DB
DB_PASS: ${FROM_SHELL_ENV_VAR}
plugin:
transformer:
config:
database: ${DATABASE}
password: ${DB_PASS}
loader:
config:
target_db: ${DATABASE}
postgres_pass: ${DB_PASS} |
@z3z1ma yes and you'd be able to set |
kgpayne
pushed a commit
that referenced
this issue
Jul 6, 2022
BuzzCutNorman
pushed a commit
to BuzzCutNorman/meltano
that referenced
this issue
Jul 6, 2022
…noFile and ProjectPlugin classes (not an extra)" (meltano#6267) Co-authored-by: Amanda Folson <afolson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Note:
env
is already a first-class attribute of theEnvironment
class.Note: Just adding these will not make inheritance work (as per #5982 and #5983).
Spec:
env
is a first-class attribute ofMeltanoFile
accessible via top-levelenv:
key inmeltano.yml
)env
is a first-class attribute ofProjectPlugin
accessible via plugin-scopedenv:
keys in base and environment-specific configenv
is settable via the CLI, including with the '.' syntax (e.g.meltano --no-environment config meltano set env.MY_ENV_VAR value
)Release:
As both #5982 and #5983 depend on an
env
attribute, they should include these changes in their PR to master. This issue will be closed when either of those issues is merged tomain
.The text was updated successfully, but these errors were encountered: