Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Replace usage of deprecated locale.getdefaultlocale #7962

Closed
edgarrmondragon opened this issue Jul 27, 2023 · 0 comments · Fixed by #7964
Closed

bug: Replace usage of deprecated locale.getdefaultlocale #7962

edgarrmondragon opened this issue Jul 27, 2023 · 0 comments · Fixed by #7964
Labels
Accepting Pull Requests good first issue Good for newcomers kind/Bug Something isn't working kind/Tech Debt valuestream/Meltano

Comments

@edgarrmondragon
Copy link
Collaborator

Meltano Version

2.20.0

Python Version

3.11

Bug scope

Other

Operating System

NA

Description

The function locale.getdefaultlocale is deprecated since version 3.11, will be removed in version 3.13. It is recommended to use locale.getlocale instead.

An explanation: python/cpython#90817 (comment)

meltano/src/meltano/core/tracking/tracker.py

Line 136 in b3a550c

self.snowplow_tracker.subject.set_lang(locale.getdefaultlocale()[0])

Code

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting Pull Requests good first issue Good for newcomers kind/Bug Something isn't working kind/Tech Debt valuestream/Meltano
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Replace deprecated locale.getdefaultlocale with locale.getlocale AmirAflak/meltano
1 participant
@edgarrmondragon